TRD: updates in vdrift and ExB calibration + possibility to use slope in chi2 matching#14989
TRD: updates in vdrift and ExB calibration + possibility to use slope in chi2 matching#14989glegras wants to merge 10 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
glegras
requested review from
a team,
bazinski,
davidrohr,
f3sch and
wille10
as code owners
| return constants::MPVDEDXDEFAULT; | ||
| } | ||
| averageGain /= ngood; | ||
| return averageGain; |
There was a problem hiding this comment.
should not the averages be precalculated at initialisation and assigned to a non-persistent data member?
There was a problem hiding this comment.
A static variable in o2::trd compiles, I cant run it from where i am though. Not a fan of global variables, so maybe it's best to leave as is 🤷
| mAngleToDyA = -0.1f; | ||
| mAngleToDyB = 1.89f; | ||
| mAngleToDyC = -0.4f; | ||
| mDyB = 0.035f; |
There was a problem hiding this comment.
Should not the mRPhiB and mDyB be ideally the same? At least, how they can have opposite signs??
bazinski
left a comment
bazinski
left a comment
There was a problem hiding this comment.
Except for maybe the removal of the average calculation, nice work.
| return constants::MPVDEDXDEFAULT; | ||
| } | ||
| averageGain /= ngood; | ||
| return averageGain; |
There was a problem hiding this comment.
A static variable in o2::trd compiles, I cant run it from where i am though. Not a fan of global variables, so maybe it's best to leave as is 🤷
4 participants
No description provided.